avm2: Refactor Array.splice to ArrayStorage #21690
Merged
+638
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
kjarosh
force-pushed
the
array-splice
branch
2 times, most recently
from
fac0132 to
e3201a1
Compare
SuchAFuriousDeath
suggested changes
Sep 25, 2025
Dinnerbone
approved these changes
Oct 12, 2025
This refactor moves splice implementation from AVM2 to ArrayStorage. The goal was to improve performance of splice, which was only partially successful, as it works better, but the bottleneck is still the weird FP behavior with holes and the prototype. Nonetheless, this looks like a step in the right direction.
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor moves splice implementation from AVM2 to ArrayStorage. The goal was to improve performance of splice, which was only partially successful, as it works better, but the bottleneck is still the weird FP behavior with holes and the prototype.
Nonetheless, this looks like a step in the right direction.
CC @adrian17 @SuchAFuriousDeath