avm1: Some Function refactors
#21849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
changed the title
Function refactorsFunction refactors
moulins
force-pushed
the
avm1-function-refactors
branch
from
1e6b6dc to
e7c1f3c
Compare
moulins
changed the title
Function refactorsFunction refactors
moulins
added
A-avm1
moulins
force-pushed
the
avm1-function-refactors
branch
from
e7c1f3c to
0e682d3
Compare
moulins
force-pushed
the
avm1-function-refactors
branch
from
0e682d3 to
bd553b9
Compare
Dinnerbone
approved these changes
Oct 11, 2025
- Remove some outdated comments - Deduplicate code for `__constructor__/constructor` property definitions - Move (most of) `Executable::exec` to `Avm1Function::exec`
Also adds `Function::exec_constructor` for use by `super` calls.
It's slightly shorter, and cleaner.
This splits creating the raw `FunctionObject`, and builf the actual AVM1 `Object` that contains it.
moulins
force-pushed
the
avm1-function-refactors
branch
from
bd553b9 to
5bc91a2
Compare
Merged
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avm1::function::Executableprivate for better encapsulation;avm1/function.rs;matches bylet-elses in native methods (for shorter code).This has no behavioral changes.