web: Add possibility to run SWF tests on web #21850
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use top-level await expressions.
This patch adds possibility to run SWF tests from //tests/tests/swfs on web. Currently web-specific renderers like webgl and canvas are largely being untested. This will make it possible in the future to test them properly and make sure they work the same way as wgpu.
kjarosh
added
A-tests
|
How does this compare to #15243? |
|
There are a lot of great PRs that seem to just be forgotten :(( |
|
Looking at old conversation on Discord, it doesn't look like anyone had any objections - people just didn't get around to reviewing the PR, as often happens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds possibility to run SWF tests from //tests/tests/swfs on web.
Currently web-specific renderers like webgl and canvas are largely being untested. This will make it possible in the future to test them properly and make sure they work the same way as wgpu.
This is mostly a (working) draft, because I have to come up with a (sane) way of controlling Ruffle through web for testing (e.g. manual ticking).
Please let me know what's your thoughts about this PR.