avm1: Remove base_clip_unloaded flag in Activation
#21866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
moulins
force-pushed
the
avm1-no-base-clip-unloaded-flag
branch
from
5d84bd7 to
f6ec689
Compare
As the comment in `continue_if_base_clip_exists` said, this doesn't appear to be necessary anymore.
moulins
force-pushed
the
avm1-no-base-clip-unloaded-flag
branch
from
f6ec689 to
dc11317
Compare
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment in
continue_if_base_clip_existssaid, this doesn't appear to be necessary anymore.Manual testing for the issues mentioned in #8873 showed no regressions, so I'm reasonably confident that this is correct.