-
-
Notifications
You must be signed in to change notification settings - Fork 934
core: Add custom version strings #22167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
18966e8 to
725e719
Compare
725e719 to
cc65063
Compare
cc65063 to
bc07d84
Compare
|
It seems somewhat unfortunate to have slightly different names between CLI/web/etc: couldn't CLI use |
|
I omitted "player" from the bundle because it's under Cli I have no string feelings on, it just felt too long. |
| * [ | ||
| `[parameters]` - A list of parameters to pass to the starting movie](#parameters---a-list-of-parameters-to-pass-to-the-starting-movie) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be divided into two lines? Similarly lines below
|
I'm still wondering if we should allow producing behaviors different than FP's. I personally liked @Lord-McSweeney's idea of (optionally) passing a 4-part version. We could also use this information to infer the u8 player version so that the user doesn't have to sync those two. Plus we make sure that the content doesn't break unexpectedly and we don't produce unexpected behaviors that are not present in FP. |
|
If we had a four-part player version, we could also observe API versioning that changed between, e.g. FP 10.0.0.32 and FP 10.1 without having to reparse the entire string. Could we always store the player version as four u8s and make |
|
We could also accept |
This overrides
$version/Capabilities.versionto a custom string, if set.Available through:
--custom-player-version <CUSTOM_PLAYER_VERSION>custom_version_stringcustomPlayerVersionStringThis also changes AVM1
$version/System.capabilities.versionto use the same logic as AVM2, where it will reportWINinstead ofLNXby default.This should fix #22148