web: Add config option to hide message when Ruffle restores from bfcache #22226
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we make it an enum that select whether to restore, reload, or ask the user? |
Contributor
Author
|
In the reload scenario, how would we want that to work? Calling |
Contributor
Author
|
Added reload, but the content does briefly blink as the page itself has restored from the bfcache. Screencast.From.2025-11-13.16-01-59.mp4 |
Contributor
Author
|
The enum is |
danielhjacobs
force-pushed
the
add-bfcache-disable-option
branch
from
7cab140 to
2752865
Compare
danielhjacobs
added
A-web
danielhjacobs
force-pushed
the
add-bfcache-disable-option
branch
from
35172bf to
7d976a9
Compare
Member
|
Honestly I would prefer if we removed the message entirely. I find it annoying and not useful. Or we could at least change the default behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration option,
hideRestoredMessage, which hides the message that appears when Ruffle is restored from the bfcache. This message was added when Toad06 switched from the unload event to the pagehide event, enabling use of the bfcache.Note that the bfcache is never used with Ruffle on Chromium due to a "bug" (previously intended behavior), therefore this more-so affects Gecko (Firefox). See https://issues.chromium.org/issues/424552566. Basically, Adobe Flash Player would not work with the bfcache, so Chromium disables the bfcache on pages with embeds or objects that have SWF sources. Since modern Chromium no longer supports any plugins, including Flash, this is now unneeded code on Chromium's part.