Skip to content

Conversation

@torokati44
Copy link
Member

@torokati44 torokati44 commented Nov 13, 2025

Replaces #18581, obsoletes #19445, simplifies #21150.
See: https://github.com/cisco/openh264/releases/tag/v2.6.0

https://github.com/flathub/rs.ruffle.Ruffle will need changes after this, to refer to these libraries as "extradata", instead of using the FreeDesktop-supplied extension.

@torokati44 torokati44 added A-video T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 13, 2025
@torokati44
Copy link
Member Author

torokati44 commented Nov 13, 2025

You were right, @kjarosh! 😂 🤣 🫠 💀
Even 2.6.0 doesn't include cisco/openh264#3868 yet. 🙃 🤡
I could have sworn at least seventeen and a half years have passed since all that, so I was sure at least one OpenH264 release at all was made since then, but alas...

@Fullmetal5
Copy link
Contributor

Fullmetal5 commented Nov 14, 2025

You were right, @kjarosh! 😂 🤣 🫠 💀 Even 2.6.0 doesn't include cisco/openh264#3868 yet. 🙃 🤡 I could have sworn at least seventeen and a half years have passed since all that, so I was sure at least one OpenH264 release at all was made since then, but alas...

Talking about the linked issue on the openh264 repo but posting here since it's a Ruffle specific question.
They do seem to have HTTPS on the ciscobinary.openh264.org domain now, seems like they started doing that in May. Progress :)
Would Ruffle be interested in switching to pulling the links over HTTPS?

EDIT: Firefox has also switched to HTTPS for the domain: https://bugzilla.mozilla.org/show_bug.cgi?id=1981186

@torokati44
Copy link
Member Author

https://codecs.multimedia.cx/2023/10/hardware-acceleration-for-nihav-video-player/
https://codecs.multimedia.cx/2023/10/hw-accel-for-nihav-player-fully-done/
👀 This looks about exactly like what we could use, and he has previously granted us permission to use multiple pieces of his code.

@torokati44
Copy link
Member Author

torokati44 commented Nov 17, 2025

@Fullmetal5

They do seem to have HTTPS on the ciscobinary.openh264.org domain now, seems like they started doing that in May. Progress :)
Would Ruffle be interested in switching to pulling the links over HTTPS?

Sure, it would be nice. But the current cert on that domain expires in ... just a little over six months.
I simply do not trust them to not forget renewing it and leaving it expired for so long again...

@Fullmetal5
Copy link
Contributor

@Fullmetal5

They do seem to have HTTPS on the ciscobinary.openh264.org domain now, seems like they started doing that in May. Progress :)
Would Ruffle be interested in switching to pulling the links over HTTPS?

Sure, it would be nice. But the current cert on that domain expires in ... just a little over six months. I simply do not trust them to not forget renewing it and leaving it expired for so long again...

Understandable, I have the same worry. It should help that Mozilla has switched to using it as they likely would have more push to get them to fix it if there were issues.

How about waiting the 6 months to see if they renew it successfully at least once and then going from there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-video T-chore Type: Chore (like updating a dependency, it's gotta be done)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants