Skip to content

修复Trigger未清除过期数据问题 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ginwyboo wants to merge 1 commit into from
Closed

修复Trigger未清除过期数据问题 #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions window/sliding_window.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,12 +650,6 @@ func (sw *SlidingWindow) Trigger() {

// Extract Data fields to form []interface{} type data for current window
resultData := make([]types.Row, 0)
for _, item := range sw.data {
if sw.currentSlot.Contains(item.Timestamp) {
item.Slot = sw.currentSlot
resultData = append(resultData, item)
}
}

// Retain data that could be in future windows
// For sliding windows, we need to keep data that falls within:
Expand All @@ -666,8 +660,12 @@ func (sw *SlidingWindow) Trigger() {
cutoffTime := next.End.Add(sw.size)
newData := make([]types.Row, 0)
for _, item := range sw.data {
// Keep data that could be in future windows (before cutoffTime)
if item.Timestamp.Before(cutoffTime) {
if sw.currentSlot.Contains(item.Timestamp) {
item.Slot = sw.currentSlot
resultData = append(resultData, item)
}
// Keep data that could be in future windows (before cutoffTime && After next.Start)
if item.Timestamp.Before(cutoffTime) && item.Timestamp.After(*next.Start) && item.Timestamp.Equal(*next.Start) {
newData = append(newData, item)
}
}
Expand Down
Loading