Revert "Fix macros to work with rust 1.46" #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3aa5e3e.
jplatte
force-pushed
the
jplatte/revert-macro-hack
branch
from
05e4cb6 to
58b041d
Compare
FSMaxB
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3aa5e3e.
I want to change the
serdedependency to be on the newserde_corecrate. I don't want to have an implicitserde_coreCargo feature though, which means usingdep:syntax for enabling the optional dependency, which requires Rust 1.60. May as well get the nicer panic message and simpler implementation for the macros then.I'll probably ship this together with #39 as js_int v0.3.0.