Conversation
jplatte
approved these changes
May 9, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Could merge the two jobs in this workflow into one then. (that doesn't use with.command at all)
GitHub disables scheduled jobs if there hasn't been activity on the repository for the last 60 days. This is likely to happen a lot here since we will probably only update it after breaking ruma releases that should happen every 6 months or so, so we remove the schedule job. Since both jobs are now always running with the same conditions, we can just merge them.
Some dependencies require that version.
zecakeh
force-pushed
the
zecakeh/rm-scheduled-job
branch
from
83a9587 to
277b331
Compare
Contributor
Author
|
Nice catch, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub disables scheduled jobs if there hasn't been activity on the repository for the last 60 days. This is likely to happen a lot here since we will probably only update it after breaking ruma releases that should happen every 6 months or so.