feat: Add room details api #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jan 16, 2025
kilimnik
force-pushed
the
room_details
branch
from
d3726a3 to
aab292a
Compare
zecakeh
reviewed
Jan 18, 2025
Contributor
zecakeh
left a comment
zecakeh
left a comment
There was a problem hiding this comment.
I am wondering if we should just reuse RoomDetails from the list_rooms endpoint given that this just adds 4 extra fields to it.
kilimnik
force-pushed
the
room_details
branch
from
aab292a to
e846725
Compare
zecakeh
reviewed
Jan 18, 2025
Contributor
zecakeh
left a comment
zecakeh
left a comment
There was a problem hiding this comment.
Could you also add a changelog entry?
kilimnik
force-pushed
the
room_details
branch
3 times, most recently
from
b0a9eff to
20a65bc
Compare
zecakeh
reviewed
Jan 18, 2025
zecakeh
reviewed
Jan 18, 2025
kilimnik
force-pushed
the
room_details
branch
2 times, most recently
from
3d001fc to
2bec9a9
Compare
Contributor
|
You need to rebase this on main to solve conflicts. |
kilimnik
force-pushed
the
room_details
branch
from
2bec9a9 to
6d0839d
Compare
Contributor
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the room details api from here https://github.com/element-hq/synapse/blob/master/docs/admin_api/rooms.md#room-details-api