feat: Improve CI #32
Merged
feat: Improve CI #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecakeh
commented
Mar 3, 2025
zecakeh
force-pushed
the
zecakeh/improve-ci
branch
4 times, most recently
from
b00faf8 to
cdce64d
Compare
jplatte
approved these changes
Mar 3, 2025
zecakeh
force-pushed
the
zecakeh/improve-ci
branch
from
aead92c to
4b8dd4c
Compare
zecakeh
force-pushed
the
zecakeh/improve-ci
branch
from
4b8dd4c to
09ef09e
Compare
Add most of the same checks as for ruma.
Because of the private variant, which shouldn't be matched, they should never be exhaustive.
This is better to avoid breaking changes when fields are added.
zecakeh
force-pushed
the
zecakeh/improve-ci
branch
from
09ef09e to
0ea5817
Compare
jplatte
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add most of the same checks as for ruma.