Skip to content

Conversation

@EmanuelCampos
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,422 @@
{
Copy link
Contributor

@logan-markewich logan-markewich Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #6.    !pip install git+https://github.com/FlagOpen/FlagEmbedding.git

Seems like all these are not needed? I think we can simplify

%pip install llama-index-core llama-cloud-services llama-index-llms-openai

Reply via ReviewNB

@@ -0,0 +1,422 @@
{
Copy link
Contributor

@logan-markewich logan-markewich Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #7.    !pip install llama-parse

nit: use llama-cloud-services


Reply via ReviewNB

@@ -0,0 +1,422 @@
{
Copy link
Contributor

@logan-markewich logan-markewich Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    from llama_index.indices.managed.llama_cloud import LlamaCloudIndex

nit: should be using llama-cloud-services


Reply via ReviewNB

@@ -0,0 +1,422 @@
{
Copy link
Contributor

@logan-markewich logan-markewich Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #4.    index = LlamaCloudIndex(

You never upload the documents?

See https://github.com/run-llama/llama_cloud_services/blob/main/examples/index/getting_started.ipynb


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants