Skip to content

Conversation

NoahStapp
Copy link
Contributor

Description

Motor is officially deprecated in favor of the asynchronous API added to PyMongo in 4.13: https://github.com/mongodb/motor. This PR replaces Motor with that API in all LlamaIndex MongoDB integrations and updates dependencies accordingly.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@NoahStapp NoahStapp marked this pull request as ready for review September 16, 2025 13:52
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 16, 2025
@NoahStapp
Copy link
Contributor Author

Passing tests in our testing pipeline repo: mongodb-labs/ai-ml-pipeline-testing#101.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caseyclements
Copy link
Contributor

Hi @logan-markewich. This is a small upgrade as our core python driver, pymongo, now contains an asynchronous client. We are deprecating motor. Would you please review?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 18, 2025
@logan-markewich logan-markewich merged commit 233f60f into run-llama:main Sep 18, 2025
10 of 11 checks passed
@caseyclements
Copy link
Contributor

Thanks @logan-markewich!

frankiekim5 pushed a commit to frankiekim5/bedrock-agentcore-memory that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants