Skip to content

Conversation

@jun76
Copy link

@jun76 jun76 commented Nov 7, 2025

Description

I added the from_persist_dir interface to the IngestionCache class. This is intended for use when utilizing IngestionPipeline without using load, instead directly passing pre-generated instances of docstore and cache. It was implemented to resolve the imbalance where from_persist_dir exists on the docstore side but not on the cache side.

Additionally, while creating the test case for the newly added from_persist_dir (test_pipeline_with_preload_from_persist_dir @test_pipeline.py), I discovered that The existing test cases test_save_load_pipeline and test_save_load_pipeline_without_docstore were re-running the first pipeline after the second pipeline generation to verify dedup. This seemed inconsistent with the intended behavior, so I corrected it as well.

After adding from_persist_dir and fixing the test cases, I confirmed all tests pass.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant