Bug: asyncio.run fails when synchronous method is called from already running async context #20240
+11
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from llama_index.core.async_utils import asyncio_runinstead ofasyncio.run()to make sure the synchronous methods also work inside a asyncio event loop.Regression caused in PR:
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods