Fix: add model parameter and improve response parsing for vllm v1/completions #20258
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with vllm 0.7.3 and confirmed compatibility with both new (choices-based) and legacy (top-level text) response formats.
Fix: add model parameter and improve response parsing for v1/completions
Description
Add model parameter to vllm v1/completions requests to resolve "missing Field required" errors, as the vllm API requires both model and prompt fields. Adjust response parsing to extract text from choices field (compatible with recent vllm versions) while preserving fallback to top-level text field for backward compatibility with older versions.
Fixes # (issue)
This addresses two issues:
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods