rag-cli: ensure chat_engine validator runs#20833
Open
noor-malaika wants to merge 1 commit intorun-llama:mainfrom
Open
rag-cli: ensure chat_engine validator runs#20833noor-malaika wants to merge 1 commit intorun-llama:mainfrom
noor-malaika wants to merge 1 commit intorun-llama:mainfrom
Conversation
dosubot
bot
added
the
size:XS
AstraBert
approved these changes
Mar 2, 2026
Member
|
You need to bump the version of the CLI before merging so that it will be published |
noor-malaika
force-pushed
the
bugfix/rag-cli-chat-failed
branch
from
74d5d34 to
93e0672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
validate_default=Truetochat_engineField so the@field_validator(..., mode="before")fires even when the default is None.Fixes # (20783)
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change