Fix FunctionTool not respecting pydantic Field defaults#20839
Open
Br1an67 wants to merge 1 commit intorun-llama:mainfrom
Open
Fix FunctionTool not respecting pydantic Field defaults#20839Br1an67 wants to merge 1 commit intorun-llama:mainfrom
Br1an67 wants to merge 1 commit intorun-llama:mainfrom
Conversation
Extract actual default values from FieldInfo objects in the function signature during __init__ and apply them as lowest-priority defaults when calling the function. This ensures that pydantic Field defaults are used when arguments are not explicitly provided.
AstraBert
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
FunctionToolto properly resolve pydanticField(default=...)values when calling the wrapped function. Previously, if a function parameter usedField(default="Berlin")and wasn't explicitly provided at call time, the rawFieldInfoobject was passed instead of the actual default value.The fix extracts actual default values from
FieldInfoobjects during__init__and applies them as lowest-priority defaults incall()andacall().Fixes #17324
New Package?
N/A
Version Bump?
N/A — bug fix only.
Type of Change
How Has This Been Tested?
Added
test_function_tool_field_defaultthat creates a function withField(default="Berlin"), wraps it inFunctionTool, and verifies:All 20 existing tests continue to pass.
Suggested Checklist: