fix(lancedb): paginate table existence checks#20841
Merged
AstraBert merged 2 commits intorun-llama:mainfrom Mar 2, 2026
Merged
fix(lancedb): paginate table existence checks#20841AstraBert merged 2 commits intorun-llama:mainfrom
AstraBert merged 2 commits intorun-llama:mainfrom
Conversation
0b485e4 to
3c4c5a4
Compare
AstraBert
approved these changes
Mar 2, 2026
Member
|
You need to bump the version of the integration before merging :) |
Contributor
Author
|
Thanks for your review. Just pushed version bump up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes LanceDB table existence checks when the target table is not in the first page of
table_names()results.Fixes #19902
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
How Has This Been Tested?
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods