Skip to content

fix(lancedb): paginate table existence checks#20841

Merged
AstraBert merged 2 commits intorun-llama:mainfrom
it-education-md:fix/lancedb-table-exists-pagination
Mar 2, 2026
Merged

fix(lancedb): paginate table existence checks#20841
AstraBert merged 2 commits intorun-llama:mainfrom
it-education-md:fix/lancedb-table-exists-pagination

Conversation

@it-education-md
Copy link
Contributor

Description

Fixes LanceDB table existence checks when the target table is not in the first page of table_names() results.

Fixes #19902

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 2, 2026
@it-education-md it-education-md force-pushed the fix/lancedb-table-exists-pagination branch from 0b485e4 to 3c4c5a4 Compare March 2, 2026 04:31
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 2, 2026
@AstraBert
Copy link
Member

You need to bump the version of the integration before merging :)

@it-education-md
Copy link
Contributor Author

Thanks for your review. Just pushed version bump up!

@AstraBert AstraBert enabled auto-merge (squash) March 2, 2026 11:35
@AstraBert AstraBert merged commit a771a4f into run-llama:main Mar 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: LanceDB integration not functioning when > 10 tables

2 participants