feat(project-acls): add support for project acl api endpoint handling#4
Open
codydiehl wants to merge 1 commit intorundeck:masterfrom
Open
feat(project-acls): add support for project acl api endpoint handling#4codydiehl wants to merge 1 commit intorundeck:masterfrom
codydiehl wants to merge 1 commit intorundeck:masterfrom
Conversation
Author
|
terraform-provider Draft PR: rundeck/terraform-provider-rundeck#234 |
Author
|
I see i updated the legacy... let me look into the rundeck-v2 ACL methods. |
Contributor
|
Yes. We will be moving everything to the V2 over time. Anything new should be using that. That one is built based on our OpenAPI spec so if what you need isn't there Open and issue in the Terraform repo and I can chase everything down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Description
Extends the ACL Policy support to include Project ACL support in addition to the existing System ACL support it had.
Type of Change
How Has This Been Tested?
I have built the terraform-provider-rundeck with this module locally and was able to build both project and system level ACL policies in my rundeck instance.
Breaking Changes
N/A
Additional Notes
There is another PR as well for the terraform provider i will be including but this is needed first.
I am not 100% positive on running the unit tests, can you clarify how i can do that and ill test that before moving this from a draft.