Skip to content

Conversation

@hirzalla
Copy link
Contributor

Displays an overlay/infobox with maximum hit values for NPCs during combat. Pulls data from the Wiki and parses it.

@runelite-github-app
Copy link

runelite-github-app bot commented Mar 25, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Mar 25, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@hirzalla
Copy link
Contributor Author

should be good for a review ^

a potential improvement in the future might be to use weirdgloop's osrs-dps-calc scraped monsters data instead of asking wiki on demand, but as of now that data doesn't properly include the only data I need for this plugin pretty much (I do have a PR to sort that out) and has more than what the plugin needs atm - it'd also be a another dependency to keep in mind, but could be worth it at some point if it turns out to be that way

currently I do have caching going on by npc ID for requests fired so shouldn't be too bad I don't think, don't expect too many happening quickly. getting this out to the wild should help get some user feedback and possibly other improvements/changes

@LlemonDuck LlemonDuck merged commit 82c3755 into runelite:master Mar 30, 2025
2 of 3 checks passed
@hirzalla hirzalla deleted the npc-max-hit branch March 30, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants