-
Notifications
You must be signed in to change notification settings - Fork 108
build: add linux release automation and release automation validation #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@pendo324 shall we close this or you do plan to get back to this in the future? |
28daa2e to
fe0f564
Compare
6533074 to
60f9d36
Compare
14b534f to
7b0b98e
Compare
|
@pendo324 PTAL when you get a chance. |
LGTM just waiting for the tests to pass |
| container_report: ${{ steps.set-multiple-vars.outputs.CONTAINER_REPORT }} | ||
| vm_serial_report: ${{ steps.set-multiple-vars.outputs.VM_SERIAL_REPORT }} | ||
| steps: | ||
| - name: Clean macOS runner workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? The cleanup of runner workspace should be automatic right?
84eaac0 to
98f3955
Compare
…tion Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
98f3955 to
f75cb0e
Compare
|
Ideally, we would only run the tests which are actually relevant for the changes which are being made. So for a change by the automated release-please PR (a change to the changelog file), we'd only run the release CI (and exit early or skip the rest of the CI). Same for the other CI types |
Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
c12b808 to
8e6e715
Compare
Issue #, if available:
Description of changes
Testing done
Changes to CI:
ci.yamlwill continue to run on PRs.ci.yamlwill not run anymore on pushes to main.ci-release.yamlwill take the place ofci.yamlon pushes to main.ci-release.yamlcallci.yamlinternally.ci-release.yamlwill also run on PRs when changes are made to installer builders/workflows.Contribution agreement
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.