feat(macOS): Add finch vm disk usage command #1491
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cartrius Phipps <cartrius@amazon.com>
| @@ -0,0 +1,98 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
have we looked into implementing equivalent of
https://docs.docker.com/reference/cli/docker/system/df/
I think this implementation will be appropriately set there.
Contributor
There was a problem hiding this comment.
I looked into the code base and this seems a lot more complex. I think it's probably a lot more maintainable to just use CLI commands.
sondavidb
approved these changes
Sep 3, 2025
Shubhranshu153
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
finch vm disk usagecommand to allow users to see detailed disk information (filesystem, mount-point, total size, used space, available space, usage percentage) when their VM is runningTesting done:
Added unit-tests for newly created
finch vm disk usageRan command locally on macOS
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.