Skip to content

feat: enable healthchecks #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Swapnanil-Gupta merged 8 commits into from
Jan 12, 2026
Merged

feat: enable healthchecks #1655

Swapnanil-Gupta merged 8 commits into from
Jan 12, 2026

Conversation

@Swapnanil-Gupta
Copy link
Contributor

@Swapnanil-Gupta Swapnanil-Gupta commented Jan 7, 2026 •
edited
Loading

Issue #, if available:

Description of changes:

  • bumps nerdctl library to v2.2.1
  • bumps github.com/containerd/cgroups package to v3
  • go mod tidy
  • update submodule finch-core to latest (which updates nerdctl and containerd to v2.2.1, buildkit to 0.26.3, finch-daemon to v0.21.0)
  • enable healthchecks
  • fixes parsing to command flags with negative integer values

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Swapnanil-Gupta
deps: bump nerdctl, enable healthchecks
f8d6e64 
Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta mentioned this pull request Jan 7, 2026
Closed
1 task
@Swapnanil-Gupta
update github.com/containerd/cgroups package to v3
fb2910a 
Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta changed the title deps: bump nerdctl, enable healthchecks build(deps): bump nerdctl, cgroups & enable healthchecks Jan 7, 2026
@Swapnanil-Gupta
bump common-tests so healthchecks are skipped on nerdctl<2.2.1
c104635 
Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta
bump finch-core which internally rolls back finch daemon to 0.20.0 fr…
22c6347 
…om 0.21.0

Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the enable-health-checks branch 2 times, most recently from 8351f47 to f97897e Compare January 9, 2026 02:03
@Swapnanil-Gupta
Changes:
602bb0c 
- bump finch-core again so that we revert back to finch-daemon 0.21
- update AL tests workflow to overwrite nerdctl version in CI

Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta
update expected dependency versions in vm serial tests
d3fddae 
Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the enable-health-checks branch 3 times, most recently from 904a398 to de26e8d Compare January 9, 2026 23:44
@Swapnanil-Gupta
fix handling of flags that can have negative integer values
d5c9d9d 
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta mentioned this pull request Jan 10, 2026
Closed
@Swapnanil-Gupta Swapnanil-Gupta marked this pull request as ready for review January 10, 2026 02:45
@Swapnanil-Gupta Swapnanil-Gupta requested a review from a team as a code owner January 10, 2026 02:45
@Swapnanil-Gupta Swapnanil-Gupta changed the title build(deps): bump nerdctl, cgroups & enable healthchecks feat: enable healthchecks Jan 10, 2026
Shubhranshu153
Shubhranshu153 previously approved these changes Jan 12, 2026
View reviewed changes
ayush-panta
ayush-panta previously approved these changes Jan 12, 2026
View reviewed changes
Kern--
Kern-- reviewed Jan 12, 2026
View reviewed changes
@Swapnanil-Gupta
fix inNumericArg function and add unit tests for handleFlagArg function
f903949 
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
@coderbirju
Copy link
Contributor

coderbirju commented Jan 12, 2026

We need documentation about using health checks in finch, something similar to https://github.com/containerd/nerdctl/blob/main/docs/healthchecks.md

@Swapnanil-Gupta
Copy link
Contributor Author

Swapnanil-Gupta commented Jan 12, 2026

We need documentation about using health checks in finch, something similar to https://github.com/containerd/nerdctl/blob/main/docs/healthchecks.md

Thanks. I will add it.

@Swapnanil-Gupta Swapnanil-Gupta merged commit 93ead3d into runfinch:main Jan 12, 2026
124 of 127 checks passed
@github-actions github-actions bot mentioned this pull request Dec 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kern-- Kern-- Kern-- approved these changes

@Shubhranshu153 Shubhranshu153 Shubhranshu153 approved these changes

@ayush-panta ayush-panta ayush-panta left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Swapnanil-Gupta @coderbirju @Kern-- @Shubhranshu153 @ayush-panta