feat(logger): Improved batch featured for logger, added structure for stream mode support. by Murike · Pull Request #456 · rungalileo/galileo-js

Murike · 2026-01-12T10:39:48Z

User description

(TS SDK Parity Effort) Refactor - Galileo Logger

[sc-44815] - https://app.shortcut.com/galileo/story/44815/ts-sdk-parity-effort-refactor-galileo-logger-logger-parity

Description

Added ingestionHook support
Added Project ID and Log Stream ID Support
Added structure to support stream mode, including:
1. Supporting traceId and spanId in logger creation
2. Streaming methods (ingest and update, span and trace)
3. All existing methods refactored to support cases of streaming mode

Obs.: Streaming will still go through further improvement in future tasks.

Generated description

Below is a concise technical summary of the changes proposed in this PR:
Refactor the GalileoLogger to support streaming mode and improve batch functionality as part of the TypeScript SDK parity effort. Introduce a TaskHandler for managing asynchronous API requests with dependency tracking and implement a robust EventSerializer for complex object serialization.

Topic Details

Serialization & Types

Enhance data serialization and type consistency across the SDK by introducing a new EventSerializer for handling complex JavaScript objects, refining toJSON methods for various span and step types, and updating type definitions to use camelCase and new JSON-serializable types.

Modified files (14)

src/entities/serialization.ts
src/types/logging/session.types.ts
src/types/logging/span.types.ts
src/types/logging/step.types.ts
src/types/logging/trace.types.ts
src/types/metrics.types.ts
src/utils/experiments.ts
src/utils/log-streams.ts
src/utils/metrics.ts
src/utils/serialization.ts
tests/entities/serialization.test.ts
tests/types/logging/step.types.test.ts
tests/utils/experiments.test.ts
tests/utils/metrics.test.ts

Latest Contributors(2)

User	Commit	Date
Murike	feat-metrics-Added-mis...	November 24, 2025
juandrucker@rungalileo.io	feat-support-ingesting...	July 25, 2025

Streaming & Logger Core

Implement streaming mode support in GalileoLogger, including the TaskHandler for managing concurrent asynchronous tasks, AsyncLocalStorage for context propagation, and updated API client methods for trace and span ingestion and updates. This also includes new configuration options for projectId, logStreamId, traceId, and spanId.

Modified files (12)

package-lock.json
package.json
src/api-client/galileo-client.ts
src/api-client/services/trace-service.ts
src/singleton.ts
src/types/logging/logger.types.ts
src/utils/galileo-logger.ts
src/utils/retry-utils.ts
src/utils/task-handler.ts
tests/utils/galileo-logger.test.ts
tests/utils/retry-utils.test.ts
tests/utils/task-handler.test.ts

Latest Contributors(2)

User	Commit	Date
Murike	feat-experiments-Added...	January 09, 2026
jweiler@galileo.ai	chore-deps-Bump-versio...	December 22, 2025

This pull request is reviewed by Baz. Review like a pro on (Baz).

src/utils/experiments.ts

src/utils/metrics.ts

src/types/metrics.types.ts

tests/utils/metrics.test.ts

src/utils/task-handler.ts

src/singleton.ts

src/entities/serialization.ts

src/utils/galileo-logger.ts

src/utils/retry-utils.ts

src/utils/task-handler.ts

fernandocorreia-galileo

Please look at test coverage. This is what Claude reported:

Missing Tests for New Features

No tests for streaming mode functionality
No tests for TaskHandler class
No tests for retry logic
No tests for EventSerializer edge cases
Tests only cover batch mode scenarios (tests/utils/galileo-logger.test.ts:154-256)

Also see the other comments below.

src/api-client/services/trace-service.ts

src/utils/galileo-logger.ts

fernandocorreia-galileo · 2026-01-13T22:00:05Z

src/utils/retry-utils.ts

+        throw error;
+      }
+      // Non-retryable exception - log and return null
+      console.error(`Unrecoverable failure or unrecognized error: ${error}`);


I think that a retry function like this one must either return a union type of T | Error, or at least have a hook for error handling like onExhausted?: (error: Error, attemptsMade: number) => void;. Logging to console and silently failing is not a solid foundation.

We should discuss the design choice of logging errors for streaming mode vs other options.

src/utils/task-handler.ts

fernandocorreia-galileo · 2026-01-13T22:09:26Z

src/utils/retry-utils.ts

+    return false;
+  }
+  return (
+    statusCode === 404 ||


Retrying on 404 by default does not seem to make sense.

What's the use case that you have in mind for this? Is this for retrying until a resource is ingested?

We get 404 if the trace we try to update doesn't exist, so we retry in case there was a delay on ingesting it in a previous task.
Although trace updating should have the ingestion as a parent task, this retry exists as precaution.

The issue is that this should be a generic function that can be used for any operation, not just traces.

In a future iteration I recommend refactoring this to use a more restrictive set of retriable errors, and allow specific use cases to add new ones.

src/utils/galileo-logger.ts

tests/utils/galileo-logger.test.ts

Murike · 2026-01-15T22:23:30Z

Please look at test coverage. This is what Claude reported:

Missing Tests for New Features
* No tests for streaming mode functionality

* No tests for TaskHandler class

* No tests for retry logic

* No tests for EventSerializer edge cases

* Tests only cover batch mode scenarios (tests/utils/galileo-logger.test.ts:154-256)
Also see the other comments below.

Added missing test cases. These will be reviewed with following tasks that continue work on streaming mode.

src/types/logging/span.types.ts

src/types/logging/logger.types.ts

fernandocorreia-galileo · 2026-01-16T18:45:43Z

src/utils/retry-utils.ts

+    return false;
+  }
+  return (
+    statusCode === 404 ||


The issue is that this should be a generic function that can be used for any operation, not just traces.

In a future iteration I recommend refactoring this to use a more restrictive set of retriable errors, and allow specific use cases to add new ones.

… stream mode support.

…ned/null, handleTaskFailure added to support parent tasks failures, removed underscore from private methods.

… error message, reusing repeated code into ensureClientInitialized().

baz-reviewer bot approved these changes Jan 12, 2026

View reviewed changes

Murike force-pushed the feature/parity-logger branch from a1accf4 to 9160788 Compare January 12, 2026 11:50

baz-reviewer bot reviewed Jan 12, 2026

View reviewed changes

src/utils/experiments.ts Outdated Show resolved Hide resolved

src/utils/metrics.ts Outdated Show resolved Hide resolved

src/types/metrics.types.ts Show resolved Hide resolved

baz-reviewer bot reviewed Jan 12, 2026

View reviewed changes

tests/utils/metrics.test.ts Outdated Show resolved Hide resolved

baz-reviewer bot reviewed Jan 12, 2026

View reviewed changes

src/utils/task-handler.ts Outdated Show resolved Hide resolved

src/singleton.ts Show resolved Hide resolved

src/entities/serialization.ts Show resolved Hide resolved

src/utils/galileo-logger.ts Outdated Show resolved Hide resolved

src/utils/retry-utils.ts Show resolved Hide resolved

baz-reviewer bot reviewed Jan 13, 2026

View reviewed changes

src/utils/task-handler.ts Outdated Show resolved Hide resolved

fernandocorreia-galileo requested changes Jan 13, 2026

View reviewed changes

fernandocorreia-galileo reviewed Jan 13, 2026

View reviewed changes

src/utils/galileo-logger.ts Show resolved Hide resolved

baz-reviewer bot reviewed Jan 14, 2026

View reviewed changes

src/utils/galileo-logger.ts Outdated Show resolved Hide resolved

src/utils/galileo-logger.ts Outdated Show resolved Hide resolved

baz-reviewer bot reviewed Jan 14, 2026

View reviewed changes

src/utils/galileo-logger.ts Outdated Show resolved Hide resolved

src/utils/galileo-logger.ts Show resolved Hide resolved

src/utils/galileo-logger.ts Outdated Show resolved Hide resolved

baz-reviewer bot reviewed Jan 14, 2026

View reviewed changes

tests/utils/galileo-logger.test.ts Show resolved Hide resolved

baz-reviewer bot reviewed Jan 14, 2026

View reviewed changes

tests/utils/galileo-logger.test.ts Outdated Show resolved Hide resolved

baz-reviewer bot approved these changes Jan 15, 2026

View reviewed changes

baz-reviewer bot reviewed Jan 15, 2026

View reviewed changes

src/types/logging/span.types.ts Show resolved Hide resolved

baz-reviewer bot reviewed Jan 15, 2026

View reviewed changes

src/types/logging/logger.types.ts Show resolved Hide resolved

baz-reviewer bot approved these changes Jan 15, 2026

View reviewed changes

Murike requested a review from fernandocorreia-galileo January 15, 2026 23:11

fernandocorreia-galileo approved these changes Jan 16, 2026

View reviewed changes

Murike added 10 commits January 16, 2026 17:57

feat(logger): Improved batch featured for logger, added structure for…

9ec7426

… stream mode support.

feat(logger): Fixed conflicts from previous experiments commit.

2eb65e7

feat(logger): Removed redundant block from git rebase merge.

148bdb7

fix(logger): Removed default empty string for serialization of undefi…

fde5c7b

…ned/null, handleTaskFailure added to support parent tasks failures, removed underscore from private methods.

fix(logger): Improved retry util to better support non retryable errors.

7d94e75

fix(logger): Task handler overhaul, substituted magic number in logger.

9488496

fix(logger): Removed unecessary validation.

9d2bcbe

fix(logger): Adjustments to initSpan and initTrace workflows, updated…

4c65565

… error message, reusing repeated code into ensureClientInitialized().

fix(logger): Updated error message on test.

f04f93c

fix(logger): Added tests, improved workflow on task-handler.

694aa8f

Murike added 3 commits January 16, 2026 17:57

fix(logger): Format manual adjustment.

bda5a4a

fix(logger): Format manual adjustment (2).

83f214e

fix(logger): Format manual adjustment (3).

250f2a5

Murike force-pushed the feature/parity-logger branch from 68a31a8 to 250f2a5 Compare January 16, 2026 21:42

baz-reviewer bot approved these changes Jan 16, 2026

View reviewed changes

Murike merged commit 4183d80 into main Jan 19, 2026
8 checks passed

Murike deleted the feature/parity-logger branch January 19, 2026 22:08

Conversation

Murike commented Jan 12, 2026 • edited by baz-reviewer bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

(TS SDK Parity Effort) Refactor - Galileo Logger

[sc-44815] - https://app.shortcut.com/galileo/story/44815/ts-sdk-parity-effort-refactor-galileo-logger-logger-parity

Description

Generated description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fernandocorreia-galileo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fernandocorreia-galileo Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Murike Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fernandocorreia-galileo Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Murike Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

fernandocorreia-galileo Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Murike commented Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

fernandocorreia-galileo Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Murike commented Jan 12, 2026 •

edited by baz-reviewer bot

Loading