Conversation
fernandocorreia-galileo
requested changes
Jan 23, 2026
… unecessary request on http request layer.
…ed error logging on some stream mode functions.
…ed error logging on some stream mode functions, added and updated tests.
97f0d7a to
8d2cce6
Compare
…roved types, removed unecessary error management functions.
fernandocorreia-galileo
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
[SDK] Add Standard Error Support to TypeScript SDK
SC-51444
Description
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Introduces a standardized error handling mechanism across the TypeScript SDK by implementing the
GalileoAPIErrorclass and centralizing error validation within theBaseClient. This refactoring removes redundant error handling from individual service clients and enhances theGalileoLogger's resilience by replacing error throws with console logging in streaming modes.GalileoLoggerin streaming mode by replacing error throws withconsole.errororconsole.warncalls. This prevents process interruptions due to internal logging issues and ensures that logging operations gracefully handle unexpected states.Modified files (2)
Latest Contributors(2)
try-catchblocks and specific API exception classes, such asExperimentTagsAPIException. This change leverages the new centralized error handling inBaseClient, reducing boilerplate and improving code clarity in individual services.Modified files (3)
Latest Contributors(2)
BaseClientto centralize all API error handling logic, including parsing streaming responses and generatingGalileoAPIErrorinstances. This involves removing old error parsing methods, renamingvalidateResponsetovalidateAxiosResponse, and introducing new private methods likevalidateErrorandgenerateApiErrorto streamline error processing.Modified files (2)
Latest Contributors(2)
GalileoAPIErrorclass,GalileoAPIStandardErrorDatainterface, andisGalileoAPIStandardErrorDatatype guard to provide a structured and consistent way to represent API errors, aligning with a predefined error catalog.Modified files (2)
Latest Contributors(1)