Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 71.29% 71.29%
=======================================
Files 71 71
Lines 5947 5947
Branches 1513 1513
=======================================
Hits 4240 4240
Misses 1697 1697
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Fix any breaking changes if this pull request fails to deploy
Generated description
Below is a concise technical summary of the changes proposed in this PR:
graph LR SEARCH_LOG_STREAMS_API_("SEARCH_LOG_STREAMS_API"):::added LOG_RECORDS_PARTIAL_QUERY_API_("LOG_RECORDS_PARTIAL_QUERY_API"):::added METRICS_DB_metric_roll_ups_metric_settings_storage_("METRICS_DB (metric roll-ups / metric settings storage)"):::added GET_METRIC_SETTINGS_API_("GET_METRIC_SETTINGS_API"):::added UPDATE_METRIC_SETTINGS_API_("UPDATE_METRIC_SETTINGS_API"):::added VALIDATE_CODE_SCORER_API_("VALIDATE_CODE_SCORER_API"):::added REGISTERED_SCORER_TASK_RESULTS_("REGISTERED_SCORER_TASK_RESULTS"):::added VALIDATE_CODE_SCORER_LOG_RECORD_API_("VALIDATE_CODE_SCORER_LOG_RECORD_API"):::added SEARCH_LOG_STREAMS_API_ -- "Uses partial query to search log streams, includes metrics/counts" --> LOG_RECORDS_PARTIAL_QUERY_API_ LOG_RECORDS_PARTIAL_QUERY_API_ -- "Rolls up metrics computing num_traces/num_spans aggregates" --> METRICS_DB_metric_roll_ups_metric_settings_storage_ GET_METRIC_SETTINGS_API_ -- "Reads metric settings and roll-up configuration for UI" --> METRICS_DB_metric_roll_ups_metric_settings_storage_ UPDATE_METRIC_SETTINGS_API_ -- "Writes scorer config and roll-up methods to DB" --> METRICS_DB_metric_roll_ups_metric_settings_storage_ VALIDATE_CODE_SCORER_API_ -- "Uploads scorer, creates validation task, stores result" --> REGISTERED_SCORER_TASK_RESULTS_ VALIDATE_CODE_SCORER_LOG_RECORD_API_ -- "Validates scorer with log records, saves experiment task" --> REGISTERED_SCORER_TASK_RESULTS_ classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13pxThis pull request is reviewed by Baz. Review like a pro on <a href=https://baz.co/changes/rungalileo/galileo-js/488?tool=ast>(Baz).