Skip to content

fix: Spans loading out of order#387

Merged
jrhone merged 4 commits intomainfrom
fix/unique_span_timestamps
Nov 3, 2025
Merged

fix: Spans loading out of order#387
jrhone merged 4 commits intomainfrom
fix/unique_span_timestamps

Conversation

@jrhone
Copy link
Contributor

@jrhone jrhone commented Oct 29, 2025

Shortcut: https://app.shortcut.com/galileo/story/43691/retriever-spans-loading-after-llm-phase-even-after-being-logged-before [sc-43691]

Description: Increment span created_at timestamps if they collide for a given parent since we sort by this field and spans can appear out of order if they're created too quickly.

Tests:

  • Unit Tests Added
  • E2E Test Added (if it's a user-facing feature, or fixing a bug)

@jrhone jrhone requested a review from a team as a code owner October 29, 2025 12:44
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.32%. Comparing base (08ad4d6) to head (c0675bd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files          75       75           
  Lines        5880     5880           
=======================================
  Hits         5076     5076           
  Misses        804      804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jrhone jrhone marked this pull request as draft November 3, 2025 13:40
@jrhone jrhone marked this pull request as ready for review November 3, 2025 15:59
@jrhone jrhone requested a review from jonahe November 3, 2025 16:11
@jrhone jrhone enabled auto-merge (squash) November 3, 2025 16:16
@jrhone jrhone merged commit 915f3c8 into main Nov 3, 2025
37 of 38 checks passed
@jrhone jrhone deleted the fix/unique_span_timestamps branch November 3, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants