Open
Conversation
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the Runme Go toolchain baseline to
1.26.1:go.modtogo 1.26.1test-dockeruseGOTOOLCHAIN=autochecklockswithGOTOOLCHAIN=go1.26.1Why
The follow-up Codex notebook work pins
github.com/redpanda-data/protoc-gen-go-mcpatv0.0.0-20260323112146-887f275039cd, and that module declaresgo 1.26.1in its owngo.mod.When Runme CI stays on Go 1.25, that dependency causes build/test failures from toolchain version mismatches. This branch moves
mainto the required Go baseline first so the Codex notebook PR can stay focused on notebook/MCP behavior instead of carrying a repository-wide toolchain bump.The Makefile updates keep local/CI helper commands aligned with that baseline:
checklocks@gootherwise resolves with an older Go toolchain and then fails when vetting packages that require Go 1.26GOTOOLCHAIN=autoletsgo testfetch the module-required toolchainValidation
git diff --checkgo test ./pkg/agent/...