Fix build_rule#4744
Merged
automergerpr-permission-manager[bot] merged 4 commits intodevelopfrom Jan 23, 2025
Merged
Conversation
Member
|
@Stevengre please add a test of this behavior where appropriate. There is a testing harness for k/pyk/src/tests/unit/test_cterm.py Line 125 in 4e07d71 |
ehildenb
reviewed
Jan 22, 2025
ehildenb
reviewed
Jan 23, 2025
ehildenb
approved these changes
Jan 23, 2025
6482ee2
into
develop
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the verification of automatic generated kclaim from summarization, current build_rule may lead to
Could not determine sort of termerror because the introduction of new variables inbuild_rule.This PR tries the best to keep the sort of variables during their corresponding var introduction and keep its default behavior.