Skip to content

CSE: disable summaries when prank or expectRevert is active #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CSE: disable summaries when prank or expectRevert is active #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce582b2
Make `ISREVERTEXPECTED_CELL` and `ACTIVE_CELL` concrete in CSE
palinatolmach May 13, 2025
f876875
Update expected output w/concrete cheatcode activation sells in CSE
palinatolmach May 13, 2025
f0f746f
Merge branch 'master' into cse-concrete-cells
palinatolmach May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/kontrol/prove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,9 +977,9 @@ def _init_cterm(
init_subst.update(init_subst_test)
else:
# CSE needs to be agnostic of the following Kontrol cells
del init_subst['ACTIVE_CELL']
# `prank`'s `<active>` and `expectRevert`'s `<isRevertExpected>` cells are `false`
# to avoid branching in nested summaries
del init_subst['ISEVENTEXPECTED_CELL']
del init_subst['ISREVERTEXPECTED_CELL']
del init_subst['RECORDEVENT_CELL']
del init_subst['SINGLECALL_CELL']

Expand Down
24 changes: 24 additions & 0 deletions src/tests/integration/test-data/show/AddConst.applyOp(uint256).cse.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,18 @@ module SUMMARY-SRC%CSE%ADDCONST.APPLYOP(UINT256):0
true
</stackChecks>
<cheatcodes>
<prank>
<active>
false
</active>
...
</prank>
<expectedRevert>
<isRevertExpected>
false
</isRevertExpected>
...
</expectedRevert>
<expectedOpcode>
<isOpcodeExpected>
false
Expand Down Expand Up @@ -358,6 +370,18 @@ module SUMMARY-SRC%CSE%ADDCONST.APPLYOP(UINT256):0
true
</stackChecks>
<cheatcodes>
<prank>
<active>
false
</active>
...
</prank>
<expectedRevert>
<isRevertExpected>
false
</isRevertExpected>
...
</expectedRevert>
<expectedOpcode>
<isOpcodeExpected>
false
Expand Down
1,271 changes: 212 additions & 1,059 deletions ...how/ArithmeticCallTest.test_double_add_sub_external(uint256,uint256,uint256).cse.expected
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 24 additions & 0 deletions src/tests/integration/test-data/show/ArithmeticContract.add(uint256,uint256).cse.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,18 @@ module SUMMARY-SRC%ARITHMETICCONTRACT.ADD(UINT256,UINT256):0
true
</stackChecks>
<cheatcodes>
<prank>
<active>
false
</active>
...
</prank>
<expectedRevert>
<isRevertExpected>
false
</isRevertExpected>
...
</expectedRevert>
<expectedOpcode>
<isOpcodeExpected>
false
Expand Down Expand Up @@ -354,6 +366,18 @@ module SUMMARY-SRC%ARITHMETICCONTRACT.ADD(UINT256,UINT256):0
true
</stackChecks>
<cheatcodes>
<prank>
<active>
false
</active>
...
</prank>
<expectedRevert>
<isRevertExpected>
false
</isRevertExpected>
...
</expectedRevert>
<expectedOpcode>
<isOpcodeExpected>
false
Expand Down
Loading