Skip to content

Conversation

@anvacaru
Copy link
Contributor

Adding three new flags for the view-kcfg command to hide cells in a kcfg term.

  • --omit-code-cells: hides <program>, <jumpDests>, and the <code> cell from each account.
  • --omit-interim-cells: hides <callStack> and <interimStates>.
  • --omit-cost-cells: hides <gas>, <memoryUsed>, <callGas>, and <refund> which were not minimized automatically by the TUI.

Updating kontrol.toml template with these new flags active, by default.

Copy link
Contributor

@lucasmt lucasmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it worked when I tested it locally. I'm just leaving some suggestions on the help documentation.

dest='omit_code_cells',
default=None,
action='store_true',
help='Hide cells that contain bytecode in the TUI.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the benefit of the user, maybe we could explicitly list the cells that will be omitted here? For example:

Suggested change
help='Hide cells that contain bytecode in the TUI.',
help='Hide cells that contain bytecode in the TUI (<program>, <code> and <jumpDests>).',

dest='omit_cost_cells',
default=None,
action='store_true',
help='Hide the gas-related cells in the TUI.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above:

Suggested change
help='Hide the gas-related cells in the TUI.',
help='Hide the gas-related cells in the TUI (<gas>, <memoryUsed>, <callGas> and <refund>).',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants