feat: add --to-module, --minimize-proof, and --add-module CLI options #907
+1,210
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stevengre
force-pushed
the
jh/draft-cse
branch
5 times, most recently
from
46d7d9c to
04e8234
Compare
Add CLI options for semantics summarization evaluation: 1. `--to-module <file>` for `kmir show`: - Export proof KCFG as K module to specified file - Supports .json (KFlatModule JSON format) and .k (K text format) 2. `--minimize-proof` for `kmir show`: - Minimize the proof KCFG before displaying or exporting - Saves minimized proof back to disk 3. `--add-module <file>` for `kmir prove-rs`: - Load K module file and pass to APRProver via extra_module parameter - Currently supports JSON format only Note: The --add-module feature uses pyk's native extra_module support in APRProver. However, rules from KCFGShow.to_module() have complex partial configurations that may cause sort injection failures during Kore conversion.
Stevengre
force-pushed
the
jh/draft-cse
branch
from
04e8234 to
0f33cd3
Compare
Stevengre
requested review from
dkcumming,
jberthold and
tothtamas28
and removed request for
jberthold
tothtamas28
reviewed
Jan 15, 2026
|
|
||
| # Process LLVM definition | ||
| # Process LLVM definition (only SMIR rules, not extra module rules) | ||
| # Extra module rules are configuration rewrites that LLVM backend doesn't support |
Contributor
There was a problem hiding this comment.
This is getting a bit too complicated IMO. We should extract two helpers for the two cases of if symbolic (not in this PR though).
- Extract _write_to_module helper function in __main__.py - Use exc_info=True for better exception logging in kompile.py
tothtamas28
reviewed
Jan 15, 2026
kmir/src/kmir/__main__.py
Outdated
| k_module_text = kmir.pretty_print(k_module_readable) | ||
| to_module_path.write_text(k_module_text) | ||
| _LOGGER.info(f'Module written to: {to_module_path}') | ||
| print(f'Module written to: {to_module_path}') |
Contributor
There was a problem hiding this comment.
Consider pulling this side effect to the caller.
dkcumming
approved these changes
Jan 15, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
I think this is all good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CLI options for semantics summarization evaluation:
--to-module <file>forkmir show:--minimize-proofforkmir show:--add-module <file>forkmir prove-rs:These features enable the workflow:
kmir prove-rs -> kmir show --to-module --minimize-proof -> kmir prove-rs --add-module