Skip to content

139 enforce typescript coding style#52

Closed
asavienko wants to merge 22 commits intomasterfrom
139-enforce-typescript-coding-style
Closed

139 enforce typescript coding style#52
asavienko wants to merge 22 commits intomasterfrom
139-enforce-typescript-coding-style

Conversation

@asavienko
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from Google TypeScript Style (GTS) to a custom eslint and prettier configuration to enforce a new TypeScript coding style. The changes remove GTS dependencies and tooling while introducing custom linting and formatting configurations.

  • Replaces GTS with eslint and prettier for code formatting and linting
  • Updates build scripts to use the new linting tools
  • Adds linting step to the GitHub Actions release workflow

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.web.json Removes GTS TypeScript configuration extension
package.json Updates scripts and dependencies to replace GTS with eslint/prettier
.prettierrc.js Removes GTS-based prettier configuration
.prettierrc Adds new prettier configuration with custom formatting rules
.github/workflows/release.yml Adds linting step to CI workflow
.eslintrc.json Removes GTS-based eslint configuration
.eslintrc.js Adds new eslint configuration using rv-web-nestjs rules

package.json Outdated
"@typescript-eslint/eslint-plugin": "^5.59.8",
"@typescript-eslint/parser": "^5.59.8",
"@typescript-eslint/eslint-plugin": "^5.57",
"@typescript-eslint/parser": "^5.0",
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version range ^5.0 is too broad and could introduce breaking changes. Consider using a more specific version range like ^5.57 to match the eslint-plugin version.

Suggested change
"@typescript-eslint/parser": "^5.0",
"@typescript-eslint/parser": "^5.57",

Copilot uses AI. Check for mistakes.
package.json Outdated
"eslint": "^8.41.0",
"eslint": "^8.57.1",
"eslint-config-prettier": "^8.10.2",
"eslint-config-rv-web-nestjs": "github:runtimeverification/eslint-config-rv-web-nestjs#master",
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using #master branch for dependencies can lead to unpredictable builds. Consider pinning to a specific commit hash or tag for better stability and reproducibility.

Suggested change
"eslint-config-rv-web-nestjs": "github:runtimeverification/eslint-config-rv-web-nestjs#master",
"eslint-config-rv-web-nestjs": "github:runtimeverification/eslint-config-rv-web-nestjs#<commit-or-tag>",

Copilot uses AI. Check for mistakes.
@asavienko asavienko requested a review from yiyi-wang-rv August 13, 2025 11:11
@yiyi-wang-rv yiyi-wang-rv self-requested a review August 13, 2025 12:16
@RaoulSchaffranek
Copy link
Member

Superseded by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants