Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from Google TypeScript Style (GTS) to a custom eslint and prettier configuration to enforce a new TypeScript coding style. The changes remove GTS dependencies and tooling while introducing custom linting and formatting configurations.
- Replaces GTS with eslint and prettier for code formatting and linting
- Updates build scripts to use the new linting tools
- Adds linting step to the GitHub Actions release workflow
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.web.json | Removes GTS TypeScript configuration extension |
| package.json | Updates scripts and dependencies to replace GTS with eslint/prettier |
| .prettierrc.js | Removes GTS-based prettier configuration |
| .prettierrc | Adds new prettier configuration with custom formatting rules |
| .github/workflows/release.yml | Adds linting step to CI workflow |
| .eslintrc.json | Removes GTS-based eslint configuration |
| .eslintrc.js | Adds new eslint configuration using rv-web-nestjs rules |
package.json
Outdated
| "@typescript-eslint/eslint-plugin": "^5.59.8", | ||
| "@typescript-eslint/parser": "^5.59.8", | ||
| "@typescript-eslint/eslint-plugin": "^5.57", | ||
| "@typescript-eslint/parser": "^5.0", |
There was a problem hiding this comment.
The version range ^5.0 is too broad and could introduce breaking changes. Consider using a more specific version range like ^5.57 to match the eslint-plugin version.
| "@typescript-eslint/parser": "^5.0", | |
| "@typescript-eslint/parser": "^5.57", |
package.json
Outdated
| "eslint": "^8.41.0", | ||
| "eslint": "^8.57.1", | ||
| "eslint-config-prettier": "^8.10.2", | ||
| "eslint-config-rv-web-nestjs": "github:runtimeverification/eslint-config-rv-web-nestjs#master", |
There was a problem hiding this comment.
Using #master branch for dependencies can lead to unpredictable builds. Consider pinning to a specific commit hash or tag for better stability and reproducibility.
| "eslint-config-rv-web-nestjs": "github:runtimeverification/eslint-config-rv-web-nestjs#master", | |
| "eslint-config-rv-web-nestjs": "github:runtimeverification/eslint-config-rv-web-nestjs#<commit-or-tag>", |
…ging and publishing steps
|
Superseded by #77 |
No description provided.