Skip to content

chore(deps): update box-cli-maker to v3#144

Merged
steveiliop56 merged 1 commit intoruntipi:developfrom
sergi0g:sergi0g/update-box-cli-maker
Feb 15, 2026
Merged

chore(deps): update box-cli-maker to v3#144
steveiliop56 merged 1 commit intoruntipi:developfrom
sergi0g:sergi0g/update-box-cli-maker

Conversation

@sergi0g
Copy link
Contributor

@sergi0g sergi0g commented Feb 15, 2026

Summary by CodeRabbit

  • Chores

    • Updated Go toolchain to the latest version for improved compatibility and performance.
    • Upgraded internal dependencies to newer versions for enhanced stability and security.
  • Refactor

    • Refactored internal console rendering components to use updated libraries and improved APIs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2026

Walkthrough

This pull request upgrades the Go toolchain and dependencies, specifically migrating from box-cli-maker v2 to v3. The code is updated to use the new v3 fluent API interface, replacing struct-based configuration with method chaining and updating the rendering approach.

Changes

Cohort / File(s) Summary
Module Dependencies
go.mod
Upgrades Go toolchain to 1.24.2, replaces box-cli-maker v2 with v3, adds color and display-related indirect dependencies, and upgrades transitive dependencies including golang.org/x/sys.
Console Box Implementation
internal/components/console_box.go
Migrates from box-cli-maker v2 struct-based API to v3 fluent API using method chaining (NewBox().Style().Padding().TitlePosition().ContentAlign().Color()), and replaces Print() with fmt.Println(box.MustRender()).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the box-cli-maker dependency from v2 to v3, which aligns with the primary modifications in go.mod and internal/components/console_box.go.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
internal/components/console_box.go (1)

8-13: ⚠️ Potential issue | 🟡 Minor

Remove the unused width field from ConsoleBox struct.

The width field is accepted in NewConsoleBox() and assigned to the struct, but is never referenced in Print() or anywhere else in the codebase. It appears to be remnant from the v2 box configuration that is no longer needed with v3.

🧹 Nitpick comments (1)
internal/components/console_box.go (1)

24-32: Variable box shadows the package import — works but fragile.

On line 25, box := box.NewBox()... shadows the box package with a local variable. Go evaluates the RHS before creating the local, so the box.Double, box.Top, box.Center constants resolve to the package correctly. However, this shadowing is confusing and will break if anyone later adds code that references the package box after line 30.

Consider renaming the local variable (e.g., b or consoleBox).

Suggested fix
 func (b *ConsoleBox) Print() {
-	box := box.NewBox().
+	cb := box.NewBox().
 		Style(box.Double).
 		Padding(2, 2).
 		TitlePosition(box.Top).
 		ContentAlign(box.Center).
 		Color(b.color)
 
-	fmt.Println(box.MustRender(b.title, b.body))
+	fmt.Println(cb.MustRender(b.title, b.body))
 }

@steveiliop56 steveiliop56 merged commit 4843adc into runtipi:develop Feb 15, 2026
3 checks passed
@sergi0g sergi0g deleted the sergi0g/update-box-cli-maker branch February 16, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants