Skip to content

add Get Help and Contribute#9

Merged
ruohai0925 merged 8 commits intoruohai0925:developmentfrom
Relax-in:development
May 14, 2025
Merged

add Get Help and Contribute#9
ruohai0925 merged 8 commits intoruohai0925:developmentfrom
Relax-in:development

Conversation

@Relax-in
Copy link
Copy Markdown
Contributor

@Relax-in Relax-in commented May 9, 2025

add Get Help and Contribute

@timokoch
Copy link
Copy Markdown

Comment from JOSS review: this seems to be a copy + some exchanged words from https://github.com/AMReX-Fluids/IAMR/blob/development/CONTRIBUTING.md. It's a good idea to attribute the source in this case.

@timokoch
Copy link
Copy Markdown

Also consider: many of the mentioned topics in CONTRIBUTING.md do not apply to IAMReX (yet). For example, there hasn't been a single release tag for IAMReX while the text mentions monthly release tags. CI pipeline is failing, etc.

@ruohai0925
Copy link
Copy Markdown
Owner

Hi @Relax-in and @S-Explorer, can you help to consider Timo's comments and update this PR? We can discuss it later tomorrow.

@Relax-in
Copy link
Copy Markdown
Contributor Author

Hi @ruohai0925, Okay, no problem. Let's discuss it together later

@ruohai0925 ruohai0925 merged commit e169399 into ruohai0925:development May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants