Open
Conversation
This is fixing the compilation of several core tests and introduced only one single regression which unicode sub.
Owner
|
Principly ok, just see the errors. SVs_PADSTALE needs to be defined. |
atoomic
added a commit
to cpanel/perl-compiler
that referenced
this pull request
Sep 16, 2016
This is fixing the compilation of several core tests and introduced only one single regression which unicode sub. SVs_PADSTALE was introduced in perl 5.8.5
Collaborator
Author
|
add patch for SVs_PADSTALE to define it when it's not ( < 5.8.5 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixing the compilation of several core tests
and introduced only one single regression with unicode sub.
This is fixing several errors from the test coresuite, including 3 segfaults.
only introducing one single regression [uni/parser.t] for unicode subs
which is not really critical for now.
extract from uni/parser.t [regression]