This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Modify check without removing values#27
Open
RafPe wants to merge 1 commit intorussellcardullo:masterfrom
Open
Conversation
Owner
|
This is okay for now, but I think longer term would be better to have a single method that accepts optional values. So if we merged this it would really be short term until we get a chance to rework everything to be optional. I'll have some time to look into that next week. |
Author
|
@russellcardullo I completely agree with you that this is temporary. I believe we could help out in work towards making certain things optional. If you could merge it this week that would really help us out :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that we have method which allows update without removing of current values within HTTP checks.