This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Open
Conversation
akosveres
commented
Oct 5, 2020
akosveres
commented
- Tests added
- Readme updated
Thelin90
reviewed
Oct 7, 2020
Author
|
@russellcardullo any chance to get a review on this? Feel free to let me know if there's anything else I should do to get this merged. |
russellcardullo
suggested changes
Nov 28, 2020
Owner
russellcardullo
left a comment
russellcardullo
left a comment
There was a problem hiding this comment.
Thanks for the PR! Everything looks good, but could you change the capitalization of ExpectedIp to make how we capitalize IP consistent in all types?
pingdom/api_responses.go
Outdated
|
|
||
| // CheckResponseDNSDetails represents the details specific to DNS checks. | ||
| type CheckResponseDNSDetails struct { | ||
| ExpectedIp string `json:"expectedip,omitempty"` |
Owner
There was a problem hiding this comment.
Would you mind making the variable ExpectedIP to match how we capitalize IP in the other types?
pingdom/check_types.go
Outdated
| // DNSCheck represents a Pingdom DNS check. | ||
| type DNSCheck struct { | ||
| Name string `json:"name"` | ||
| ExpectedIp string `json:"expectedip"` |
Owner
There was a problem hiding this comment.
Can you make this ExpectedIP?
* Tests added * Readme updated
Author
All fixed, ready for review @russellcardullo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.