Optimise to_lowercase_smolstr
, to_uppercase_smolstr
#98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimisation opportunity highlighted by testing against
String
perf and using benchmarks in #96.This is slightly more involved than the ascii optimisations in #97. I ported std
convert_while_ascii
into an inline versioninline_convert_while_ascii
to get an equivalent ascii-optimistic optimisation to theString
version.PR bench
The change provides a significant perf improvement on inline & heap reprs. Also faster than String for len=12 now 🙂.
The benchmark is favourable to this optimisation as it measures a string with mostly ascii prefix. But I think this is a very common case for this method so the optimisation makes sense generally, and clearly std think so too.