Skip to content

Implement building from sources#45

Draft
shssoichiro wants to merge 2 commits intomasterfrom
build-sources
Draft

Implement building from sources#45
shssoichiro wants to merge 2 commits intomasterfrom
build-sources

Conversation

@shssoichiro
Copy link
Member

This cargo feature existed but was never actually implemented. This feature was necessary for the Rust AV1 Analyzer I'm working on, so that I can ensure that the accounting feature set is included (which is also a part of this changeset).

@shssoichiro
Copy link
Member Author

I would love some help if someone is more familiar with getting things to build properly, though. The CI is failing and I'm having trouble figuring it out.

Locally, -features build_sources works, but it fails the tests in CI. With no features, it fails both locally and in CI, but with different errors.

env::set_var("SYSTEM_DEPS_BUILD_INTERNAL", "always");
system_deps::Config::new()
.add_build_internal("aom", |lib, version| {
// Actually build the library here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you should call build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants