Add custom coefficients for cY, cCb, and cCr#30
Open
BoatsMcGee wants to merge 1 commit intorust-av:mainfrom
Open
Add custom coefficients for cY, cCb, and cCr#30BoatsMcGee wants to merge 1 commit intorust-av:mainfrom
BoatsMcGee wants to merge 1 commit intorust-av:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coefficients for the luma, Cb, and Cr planes are hard-coded to 0. This PR allows the user to specify their own coefficients to tweak the characteristics of the Film Grain table.
I have no understanding of the Film Grain specification so this is just an incremental improvement over defaulting to 0, allowing more variation in grain tables without having to extract the generated table, add the values manually, then apply them. Instead, I produce the values by using the
diffcommand, parse the table, then call thegeneratecommand with the--cy "VALUES" --ccb "VALUES" --ccy "VALUES"arguments.Improvements
Initially, I tried to simply pass an existing film grain table file location to an
--existingargument for thegeneratecommand to parse and replace the values but the parsing wasn't working as expected (no output or error). If the parsing issue could be resolved that would make thegeneratecommand cleaner and simplify usage.Ideally, a set of inputs could be used to generate values besides defaulting to 0. Without an understanding of the specification, simply copying known good values is the best I can do.
Thanks,
- Boats M.