Conversation
| clap = { version = "4.0.18", features = ["derive"] } | ||
| crossterm = "0.27.0" | ||
| indicatif = "0.17.1" | ||
| jxl-oxide = { version = "0.10.1", features = ["image"] } |
There was a problem hiding this comment.
This increases binary size from 3.4M to 6.0M on my machine.. Should probably be a feature.
|
Fix clippy errors please, and make jxl a feature. Might have to look at why this adds so much bloat before merging.. |
I need some time to figure out how I want to make it optional, this will be important for adding other formats in the future as image-rs has a policy of not taking some formats in (IE. heif will be an issue), converting to a draft until I find the time to figure this out, which has been in very short supply lately... EDIT: may also just wait for image-rs/image#2372 to blow over and utilize whatever this may look like |
|
Sure, take your time. Just added another comment because I wasn't sure that I was clear enough in my review. |
2 participants
jxl-oxide now has image interop, we can support it like so