Skip to content

Conversation

@Geal
Copy link
Collaborator

@Geal Geal commented Jan 26, 2025

No description provided.

@codecov
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.42%. Comparing base (7afe3a8) to head (01cd0bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
+ Coverage   61.36%   61.42%   +0.05%     
==========================================
  Files          25       25              
  Lines        3127     3126       -1     
==========================================
+ Hits         1919     1920       +1     
+ Misses       1208     1206       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #1797 will degrade performances by 18.7%

Comparing v8.0.0 (01cd0bd) with main (7afe3a8)

Summary

❌ 3 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
recognize float str 742.5 ns 829.7 ns -10.51%
float str streaming 2.3 µs 2.6 µs -10.63%
recognize float str streaming 1.3 µs 1.6 µs -18.7%

@Geal Geal merged commit 2cec1b3 into main Jan 26, 2025
32 of 33 checks passed
@Geal Geal deleted the v8.0.0 branch January 26, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants