-
Notifications
You must be signed in to change notification settings - Fork 88
ci: Small cleanup of the Github Actions in the PR workflow #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I could push fix for those if the maintainers of the repo say it is OK to do it in this PR! |
Pull Request Test Coverage Report for Build 13408697687Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much needed, thanks @martin-g ;)
Please fix the lint errors if you are ok doing so?
Doing it! |
|
OK! All is green! |
|
Thanks much @martin-g, LGTM. @johanneskoester, I've been approving the workflow runs and checking the changes on almost each commit, any objections from your side? |
|
@martin-g Actually, can you squash your commits a bit? CI tests tend to be a bit verbose on commit history, other than that the changes look great and code looks even better now too ;) |
Keep only the release related actions as is. The action is deprecated and should be replaces by a new one. Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Done! |
|
@martin-g We are implementing the same changes over in the |
|
The OS images (22.04 vs 24.04) come with different set of preinstalled software. |
actions-rs/toolchainaction withdtolnay/rust-toolchainactions-rs/cargowith direct usage ofcargoactions-rs/clippywith direct usage ofcargo clippy(it even shows that there are some problems in the code)