Skip to content

Conversation

@jeeeesper
Copy link
Contributor

Should close #474

@jeeeesper jeeeesper force-pushed the polyploid-genotype branch from 78461ca to d640186 Compare May 19, 2025 11:13
@jeeeesper jeeeesper changed the title Allow for non-diploid genotypes feat: Allow for non-diploid genotypes May 19, 2025
@brainstorm
Copy link
Member

Thanks @jeeeesper! Would you mind fixing up the clippy issues and add some test(s)?

@coveralls
Copy link

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 15414650642

Details

  • 21 of 25 (84.0%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 83.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bcf/record.rs 16 17 94.12%
src/bgzf/mod.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/bam/pileup.rs 2 83.64%
src/bcf/record.rs 2 83.99%
Totals Coverage Status
Change from base Build 13877817877: -0.01%
Covered Lines: 2721
Relevant Lines: 3255

💛 - Coveralls

@jeeeesper jeeeesper force-pushed the polyploid-genotype branch 2 times, most recently from b1b134c to b3663b3 Compare May 21, 2025 12:40
@jeeeesper
Copy link
Contributor Author

jeeeesper commented May 21, 2025

Thanks @brainstorm ! I added two small test cases to the original commit, and I fixed the clippy lints in an extra commit. Most of the lints were not affecting or originating in the new code, therefore the extra commit.

Edit: whoops, I missed one clippy lint (that curiously does not lint on my system but in the CI pipeline)...

@jeeeesper jeeeesper force-pushed the polyploid-genotype branch from b3663b3 to b8fdd3d Compare May 23, 2025 12:29
@jeeeesper jeeeesper force-pushed the polyploid-genotype branch from b8fdd3d to f9ddbe8 Compare June 3, 2025 10:14
@brainstorm brainstorm merged commit 1c22ac5 into rust-bio:master Jun 5, 2025
12 of 13 checks passed
@jeeeesper jeeeesper deleted the polyploid-genotype branch June 5, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dealing with mixed ploidy

3 participants