WIP: Use new rust-bitcoind-json-rpc crate #164
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new `rust-bitcoin-json-rpc` crate for RPC calls. WIP because currently only works for features "0_17_1" and "22_1". ref: https://github.com/tcharding/rust-bitcoind-json-rpc
tcharding
force-pushed
the
bitcoind-json-rpc
branch
from
3c46fe5 to
5b5c8d4
Compare
tcharding
added a commit
to rust-bitcoin/rust-bitcoind-json-rpc
that referenced
this pull request
Jun 6, 2024
The `bitcoind` crate is provided for integration testing, it is tightly coupled to the `client` and `bitcoin` crates. It might as well just live here. Import `bitcoind` at tag `v.036.0` as well as the changes in: rust-bitcoin/bitcoind#164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing this up so its public, please see rust-bitcoin/rust-bitcoin#2777 for context. FTR I am not proposing that the new
bitcoind-json-rpccrate replacebitcoincore-rpc, I just find it easier to work in a separate crate while I'm developing this (I am copying bits for the original crate as I go).Use the new
rust-bitcoin-json-rpccrate for RPC calls. WIP because currently only works for features "0_17_1" and "22_1".ref: https://github.com/tcharding/rust-bitcoind-json-rpc
This was required so that in
bitcoind-json-rpcI can useBitcoinDto runbitcoindin the integration tests.