Implement importaddress method and test #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GideonBature
force-pushed
the
importaddress
branch
from
072b578 to
b71c340
Compare
GideonBature
force-pushed
the
importaddress
branch
from
b71c340 to
859ec74
Compare
tcharding
approved these changes
Jun 19, 2025
|
We are flying crew, you blokes are killing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
importaddressdoes return null. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than
null, along with an integration test that calls this function.Ref: #116