Skip to content

Fix clippy lints in verify#262

Closed
0xZaddyy wants to merge 2 commits intorust-bitcoin:masterfrom
0xZaddyy:lint-verify
Closed

Fix clippy lints in verify#262
0xZaddyy wants to merge 2 commits intorust-bitcoin:masterfrom
0xZaddyy:lint-verify

Conversation

@0xZaddyy
Copy link
Contributor

This PR resolves all Clippy warnings in the verify crate by applying idiomatic Rust fixes and cleanup where necessary.

@0xZaddyy
Copy link
Contributor Author

@jamillambert Hi boss, i honestly don't know what i'm doing wrong.
i think i need help here

@jamillambert
Copy link
Collaborator

jamillambert commented Jun 20, 2025

There is an issue with the lockfiles because verify was added to the workspace members.

This crate uses Cargo-minimal.lock and Cargo-recent.lock which need to be updated using the script contrib/update-lock-files.sh.

The main Cargo.lock should not be tracked by git so the last patch needs to be dropped.

And can you reword the commit log of the first patch to have a heading with ≤ 50 chars, then a blank line then the rest with ≤ 72 chars per line.

@0xZaddyy 0xZaddyy changed the title Fix all clippy warning for Verify crate. Fix clippy lints in verify Jun 20, 2025
fix format errors

added cargo.lock back to gitignore

update workspace lockfiles for verify crate
@0xZaddyy
Copy link
Contributor Author

There is an issue with the lockfiles because verify was added to the workspace members.

This crate uses Cargo-minimal.lock and Cargo-recent.lock which need to be updated using the script contrib/update-lock-files.sh.

The main Cargo.lock should not be tracked by git so the last patch needs to be dropped.

And can you reword the commit log of the first patch to have a heading with ≤ 50 chars, then a blank line then the rest with ≤ 72 chars per line.

Thank you boss, i've fixed it.

@tcharding
Copy link
Member

A diff with 468 green and 68 red is suspicious for a lint PR. I did not look closely but at least these things are wrong:

  • formatting changes
  • probably changes to the root manifest are wrong though I didn't think much about it

@0xZaddyy
Copy link
Contributor Author

0xZaddyy commented Jun 21, 2025

I added verify as a workspace member so when I pushed CI was failing because there was issues with the lock files
So I had to run .contrib/update-lock-files.sh to update cargo-minimal.lock and cargo-recent.lock .

I will fix the formatting now.

@0xZaddyy 0xZaddyy closed this Jun 21, 2025
@0xZaddyy 0xZaddyy deleted the lint-verify branch June 21, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants